chore(react-tree): adds test to ensure action visibility on click#32042
Open
bsunderhus wants to merge 2 commits into
Open
Conversation
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 651 | 652 | 5000 | |
| Button | mount | 303 | 316 | 5000 | |
| Field | mount | 1140 | 1144 | 5000 | |
| FluentProvider | mount | 731 | 717 | 5000 | |
| FluentProviderWithTheme | mount | 97 | 108 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 40 | 42 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 87 | 96 | 10 | |
| MakeStyles | mount | 875 | 885 | 50000 | |
| Persona | mount | 1784 | 1736 | 5000 | |
| SpinButton | mount | 1446 | 1440 | 5000 | |
| SwatchPicker | mount | 1687 | 1683 | 5000 |
bsunderhus
marked this pull request as ready for review
July 18, 2024 08:05
bsunderhus
force-pushed
the
react-tree/chore--adds-test-to-ensure-action-visibility-on-click
branch
from
July 18, 2024 08:48
39e29dd to
c0ade1d
Compare
bsunderhus
force-pushed
the
react-tree/chore--adds-test-to-ensure-action-visibility-on-click
branch
from
July 18, 2024 10:21
c0ade1d to
69bc973
Compare
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
ling1726
reviewed
Jul 18, 2024
| value: TreeItemValue; | ||
| parentValue: TreeItemValue | undefined; | ||
| } & ( | ||
| | { event: React.FocusEvent<HTMLElement>; type: 'Focus' } |
Contributor
There was a problem hiding this comment.
isn't this a breaking change?
Contributor
Author
There was a problem hiding this comment.
Yes, it is. Any suggestions to avoid it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
We are assuming navigation on
clickevents (to ensure propertabIndexon the clicked treeitem), as described here #32034 (comment), this assumption is not correct, we should be doing that onfocusevents!New Behavior
clickeventsfocuseventsactionsslot are visible on a real clickTreeNavigationDataunion with theClickevent typeFocusevent type for theTreeNavigationDataunionRelated Issue(s)